Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Entity Personals Campaign API using CiviCRM core methods PCP examples included #9017

Closed
wants to merge 1 commit into from

Conversation

frederickgzmn
Copy link
Contributor

Features:

API Personalcampaigns.get
API Personalcampaigns.delete
Examples included, etc.

@civicrm-builder
Copy link

Can one of the admins verify this patch?

@eileenmcnaughton eileenmcnaughton mentioned this pull request Sep 13, 2016
@eileenmcnaughton
Copy link
Contributor

We actually have multiple PRs open to add this api (#9012 #9017 #7878) . #7878 stalled failing tests. I took a look and concluded some BAO changes would resolve that #8697 but no-one came back to that PR & reviewed / tested them so they never got merged & hence #7878 stalled.

I suspect if I get the tests to run you will see the same fails here. NB if you wish to test / review #8697please leave comments as to what you do.

Specific to this PR - great you have had a go at generated examples - they are actually generated from the unit tests normally - e.g https://github.com/civicrm/civicrm-core/blob/master/tests/phpunit/api/v3/PhoneTest.php#L62-L62

Also, this is quite different to our standard apis - which are much more like #7878 - we do try to keep them standardised so we'd probably need to discuss / understand a case for something different (and we would try to find a more standardised way to do it if possible)

@seamuslee001
Copy link
Contributor

this can be closed now as has been superseded by #9049

@eileenmcnaughton
Copy link
Contributor

ok thanks. If you want to revisit the non-standard parts might be best to discuss on chat.civicrm.org - but also note you can implement a custom api in an extension

@colemanw colemanw closed this Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants